github-vet / github-vet/rangeloop-pointer-findings
SwingbyProtocol/tx-indexer: chains/eth/keeper.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [SwingbyProtocol/tx-indexer](https://www.github.com/SwingbyProtocol/tx-indexer) at [chains/eth/keeper.go](https://github.com/SwingbyProtocol/tx-indexer/blob/e54d6740619fa8873b7d829cbbe232b9e270a3dc/chains/eth/keeper.go#L147-L149)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to tx is reassigned at line 148
[Click here to see the code in its original context.](https://github.com/SwingbyProtocol/tx-indexer/blob/e54d6740619fa8873b7d829cbbe232b9e270a3dc/chains/eth/keeper.go#L147-L149)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, tx := range txs {
k.txs[tx.Serialize()] = &tx
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: e54d6740619fa8873b7d829cbbe232b9e270a3dc
Contributor guide
No contributing guide indexed for this repository
Research direction
Read chains/eth/keeper.go at lines 147-149 and inspect how the range variable tx is used when populating k.txs. Compare that usage with the analyzer's range-loop capture concern and the linked source context; done means deciding whether it is a Bug, Mitigated, or Desirable Behavior and leaving the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100