github-vet / github-vet/rangeloop-pointer-findings

ngohoa211/kapacitor: services/k8s/service.go; 5 LoC

Open
#15,164 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ngohoa211/kapacitor](https://www.github.com/ngohoa211/kapacitor) at [services/k8s/service.go](https://github.com/ngohoa211/kapacitor/blob/298395c4f4733c14d0c53a7c7206e4207de10aa9/services/k8s/service.go#L76-L80)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/ngohoa211/kapacitor/blob/298395c4f4733c14d0c53a7c7206e4207de10aa9/services/k8s/service.go#L76-L80)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, d := range s.configs {
if d.Enabled {
s.registry.AddDiscoverer(&d)
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {AddDiscoverer 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 298395c4f4733c14d0c53a7c7206e4207de10aa9

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with services/k8s/service.go around lines 76-80 and inspect the AddDiscoverer call and the surrounding configuration loop. Determine whether the pointer to the range variable can be retained or otherwise cause incorrect behavior. The issue provides no patch scope; done means supporting one of the requested Bug, Mitigated, or Desirable Behavior classifications with evidence.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.