github-vet / github-vet/rangeloop-pointer-findings

ngohoa211/kapacitor: services/k8s/service.go; 3 LoC

Open
#15,163 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ngohoa211/kapacitor](https://www.github.com/ngohoa211/kapacitor) at [services/k8s/service.go](https://github.com/ngohoa211/kapacitor/blob/298395c4f4733c14d0c53a7c7206e4207de10aa9/services/k8s/service.go#L69-L71)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/ngohoa211/kapacitor/blob/298395c4f4733c14d0c53a7c7206e4207de10aa9/services/k8s/service.go#L69-L71)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, d := range s.configs {
s.registry.RemoveDiscoverer(&d)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {RemoveDiscoverer 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 298395c4f4733c14d0c53a7c7206e4207de10aa9

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open services/k8s/service.go at lines 69-71 and review the referenced commit alongside the analyzer output. Determine whether the range-loop pointer usage is a bug, mitigated, or desirable behavior, then record the appropriate classification reaction; no code change is specified as the definition of done.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.