github-vet / github-vet/rangeloop-pointer-findings

arempter/rstreams: source/source_slice.go; 5 LoC

Open
#15,139 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [arempter/rstreams](https://www.github.com/arempter/rstreams) at [source/source_slice.go](https://github.com/arempter/rstreams/blob/c038607aeb632180bd078ed80b4da23d4c0f0730/source/source_slice.go#L78-L82)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable done used in defer or goroutine at line 80

[Click here to see the code in its original context.](https://github.com/arempter/rstreams/blob/c038607aeb632180bd078ed80b4da23d4c0f0730/source/source_slice.go#L78-L82)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, done := range s.consumers {
go func() {
done <- true
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c038607aeb632180bd078ed80b4da23d4c0f0730

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with source/source_slice.go at lines 78-82 and read the surrounding consumer-handling code. Check how the range variable done is used inside the goroutine and whether the captured value can affect behavior. Compare the finding with the linked analyzer guidance, then leave the requested reaction classification when you have determined whether it is a bug, mitigated, or desirable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.