github-vet / github-vet/rangeloop-pointer-findings

koli/koli: pkg/mutator/ingress.go; 3 LoC

Open
#15,133 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [koli/koli](https://www.github.com/koli/koli) at [pkg/mutator/ingress.go](https://github.com/koli/koli/blob/75f6e1d9426c2750e7648b3a332075086dbb3b2e/pkg/mutator/ingress.go#L153-L155)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to p is reassigned at line 154

[Click here to see the code in its original context.](https://github.com/koli/koli/blob/75f6e1d9426c2750e7648b3a332075086dbb3b2e/pkg/mutator/ingress.go#L153-L155)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, p := range r.HTTP.Paths {
newIngressPaths[p.Path] = &p
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 75f6e1d9426c2750e7648b3a332075086dbb3b2e

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at pkg/mutator/ingress.go lines 153-155 and inspect the surrounding ingress mutation logic and uses of newIngressPaths. Compare the analyzer finding with that context, then leave the reaction classifying it as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.