github-vet / github-vet/rangeloop-pointer-findings

knative-sandbox/discovery: pkg/apis/discovery/v1alpha1/zz_generated.deepcopy.go; 11 LoC

Open
#15,126 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [knative-sandbox/discovery](https://www.github.com/knative-sandbox/discovery) at [pkg/apis/discovery/v1alpha1/zz_generated.deepcopy.go](https://github.com/knative-sandbox/discovery/blob/0753d2a2920e69ece8949c707dea657e06446472/pkg/apis/discovery/v1alpha1/zz_generated.deepcopy.go#L125-L135)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 130

[Click here to see the code in its original context.](https://github.com/knative-sandbox/discovery/blob/0753d2a2920e69ece8949c707dea657e06446472/pkg/apis/discovery/v1alpha1/zz_generated.deepcopy.go#L125-L135)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal []ResourceMeta
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make([]ResourceMeta, len(*in))
copy(*out, *in)
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0753d2a2920e69ece8949c707dea657e06446472

Contributor guide

No contributing guide indexed for this repository

Research direction

Read pkg/apis/discovery/v1alpha1/zz_generated.deepcopy.go around lines 125-135 and inspect the reported range-loop reference reassignment. Compare the analyzer message with the deepcopy behavior, then classify the finding as Bug, Mitigated, or Desirable Behavior using the linked project guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.