github-vet / github-vet/rangeloop-pointer-findings

Peripli/service-broker-proxy-k8s: pkg/k8s/client/client.go; 3 LoC

Open
#15,123 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Peripli/service-broker-proxy-k8s](https://www.github.com/Peripli/service-broker-proxy-k8s) at [pkg/k8s/client/client.go](https://github.com/Peripli/service-broker-proxy-k8s/blob/e53c6870f0d29686c5b97bf0a8165252b8448bea/pkg/k8s/client/client.go#L408-L410)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to clusterBroker is reassigned at line 409

[Click here to see the code in its original context.](https://github.com/Peripli/service-broker-proxy-k8s/blob/e53c6870f0d29686c5b97bf0a8165252b8448bea/pkg/k8s/client/client.go#L408-L410)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, clusterBroker := range namespaceBrokers.Items {
brokers[clusterBroker.ObjectMeta.UID] = &clusterBroker
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e53c6870f0d29686c5b97bf0a8165252b8448bea

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with pkg/k8s/client/client.go at lines 408-410 in commit e53c6870f0d29686c5b97bf0a8165252b8448bea and review the analyzer message about clusterBroker being reassigned. Determine whether the finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.