Qitmeer/qitmeer: core/blockdag/spectre.go; 20 LoC

Found a possible issue in [Qitmeer/qitmeer](https://www.github.com/Qitmeer/qitmeer) at [core/blockdag/spectre.go](https://github.com/Qitmeer/qitmeer/blob/43dfe070ff5ab00d4bf42ca540b524eaf99db0b3/core/blockdag/spectre.go#L685-L704)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 702 may store a reference to o

[Click here to see the code in its original context.](https://github.com/Qitmeer/qitmeer/blob/43dfe070ff5ab00d4bf42ca540b524eaf99db0b3/core/blockdag/spectre.go#L685-L704)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for o, ib := range outerNodes.GetMap() {
if skip.Has(&o) {
continue
}
allUpdated := votedPast.hasBlockById(ib.(IBlock).GetID())
oParents := sp.bd.getBlock(&o).GetParents()
for _, oib := range oParents.GetMap() {
ph := *oib.(IBlock).GetHash()
if !sp.updateVotes(votedPast, ph) {
allUpdated = false
break
} else if outerNodes.Has(&ph) {
skip.Add(&ph)
}
}

if allUpdated {
removing.Add(&o)
}
}

```

Click here to show extra information the analyzer produced.

```
The following graphviz dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
digraph G {
"(Add, 1)" -> {}
}

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 43dfe070ff5ab00d4bf42ca540b524eaf99db0b3

Read core/blockdag/spectre.go around lines 685-704 and review the analyzer message about storing a reference to the range variable. Determine whether the finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.