github-vet / github-vet/rangeloop-pointer-findings

flier/curator.go: state.go; 9 LoC

Open
#15,114 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [flier/curator.go](https://www.github.com/flier/curator.go) at [state.go](https://github.com/flier/curator.go/blob/366ffb7709bf81b1eb91735a78fa45916f6eaad6/state.go#L266-L274)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable watcher used in defer or goroutine at line 272

[Click here to see the code in its original context.](https://github.com/flier/curator.go/blob/366ffb7709bf81b1eb91735a78fa45916f6eaad6/state.go#L266-L274)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for _, watcher := range s.parentWatchers.watchers {
go func() {
tracer := newTimeTracer("connection-state-parent-process", s.tracer)

defer tracer.Commit()

watcher.process(event)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 366ffb7709bf81b1eb91735a78fa45916f6eaad6

Contributor guide

No contributing guide indexed for this repository

Research direction

Read state.go lines 266-274 and the analyzer report first, then inspect the surrounding state-handling code to understand how each watcher is intended to process the event. Done means the goroutines reliably process their intended watchers without the reported range-loop capture issue, with the surrounding behavior checked for regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.