github-vet / github-vet/rangeloop-pointer-findings
bosun-monitor/bosun: cmd/scollector/collectors/extrahop.go; 5 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [bosun-monitor/bosun](https://www.github.com/bosun-monitor/bosun) at [cmd/scollector/collectors/extrahop.go](https://github.com/bosun-monitor/bosun/blob/4ea808ab2ddfcd7dcc135372ea217aa17ef764cc/cmd/scollector/collectors/extrahop.go#L294-L298)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/bosun-monitor/bosun/blob/4ea808ab2ddfcd7dcc135372ea217aa17ef764cc/cmd/scollector/collectors/extrahop.go#L294-L298)
Click here to show the 5 line(s) of Go which triggered the analyzer.
```go
for _, b := range a.Values {
for _, d := range b {
pc(c, md, &a, &b, &d)
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {pc 5} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 4ea808ab2ddfcd7dcc135372ea217aa17ef764cc
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with cmd/scollector/collectors/extrahop.go around lines 294-298 and inspect the range loops and the pc call in context. Determine whether passing the range variables by pointer can cause an unintended capture or mutation, then classify the finding as Bug, Mitigated, or Desirable Behavior using the issue reactions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100