github-vet / github-vet/rangeloop-pointer-findings
revel/examples: chat/app/controllers/websocket.go; 6 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [revel/examples](https://www.github.com/revel/examples) at [chat/app/controllers/websocket.go](https://github.com/revel/examples/blob/8fe667a97699501c5c4a0820f3040930bdb2243f/chat/app/controllers/websocket.go#L31-L36)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/revel/examples/blob/8fe667a97699501c5c4a0820f3040930bdb2243f/chat/app/controllers/websocket.go#L31-L36)
Click here to show the 6 line(s) of Go which triggered the analyzer.
```go
for _, event := range subscription.Archive {
if ws.MessageSendJSON(&event) != nil {
// They disconnected
return nil
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {MessageSendJSON 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 8fe667a97699501c5c4a0820f3040930bdb2243f
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with chat/app/controllers/websocket.go at lines 31-36 and inspect the MessageSendJSON call in the range loop. Determine whether passing &event is safe for this use, then classify the finding as Bug, Mitigated, or Desirable Behavior as requested by the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100