github-vet / github-vet/rangeloop-pointer-findings

knative-sandbox/eventing-autoscaler-keda: pkg/reconciler/awssqs/awssqs.go; 5 LoC

Open
#15,101 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [knative-sandbox/eventing-autoscaler-keda](https://www.github.com/knative-sandbox/eventing-autoscaler-keda) at [pkg/reconciler/awssqs/awssqs.go](https://github.com/knative-sandbox/eventing-autoscaler-keda/blob/2e095245e788bd4b7edce8c77fe5518cf6994e85/pkg/reconciler/awssqs/awssqs.go#L57-L61)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/knative-sandbox/eventing-autoscaler-keda/blob/2e095245e788bd4b7edce8c77fe5518cf6994e85/pkg/reconciler/awssqs/awssqs.go#L57-L61)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, dep := range dl.Items {
if metav1.IsControlledBy(&dep, src) {
return dep.Name, nil
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {IsControlledBy 2} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 2e095245e788bd4b7edce8c77fe5518cf6994e85

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with pkg/reconciler/awssqs/awssqs.go at lines 57-61 and the linked commit. Inspect the range loop and metav1.IsControlledBy call, then determine whether the analyzer warning represents a bug, mitigated case, or desirable behavior. Classify the finding using the requested reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.