github-vet / github-vet/rangeloop-pointer-findings
darkblue-b/photoprism: internal/api/preview.go; 36 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [darkblue-b/photoprism](https://www.github.com/darkblue-b/photoprism) at [internal/api/preview.go](https://github.com/darkblue-b/photoprism/blob/6850326678ed2d89b01ec2e0f1fef5f28fe8c2b6/internal/api/preview.go#L65-L100)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/darkblue-b/photoprism/blob/6850326678ed2d89b01ec2e0f1fef5f28fe8c2b6/internal/api/preview.go#L65-L100)
Click here to show the 36 line(s) of Go which triggered the analyzer.
```go
for _, f := range p {
fileName := path.Join(conf.OriginalsPath(), f.FileName)
if !fs.FileExists(fileName) {
log.Errorf("could not find original for thumbnail: %s", fileName)
c.Data(http.StatusNotFound, "image/svg+xml", photoIconSvg)
// Set missing flag so that the file doesn't show up in search results anymore
f.FileMissing = true
conf.Db().Save(&f)
return
}
thumbnail, err := thumb.FromFile(fileName, f.FileHash, conf.ThumbnailsPath(), thumbType.Width, thumbType.Height, thumbType.Options...)
if err != nil {
log.Error(err)
c.Data(http.StatusNotFound, "image/svg+xml", photoIconSvg)
}
src, err := imaging.Open(thumbnail)
if err != nil {
log.Error(err)
c.Data(http.StatusNotFound, "image/svg+xml", photoIconSvg)
}
preview = imaging.Paste(preview, src, image.Pt(x, y))
x += 228
if x > width {
x = 0
y += 228
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Save 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 6850326678ed2d89b01ec2e0f1fef5f28fe8c2b6
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.