github-vet / github-vet/rangeloop-pointer-findings
markzhai/GoWebServer: router_admin_deal.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [markzhai/GoWebServer](https://www.github.com/markzhai/GoWebServer) at [router_admin_deal.go](https://github.com/markzhai/GoWebServer/blob/572a5f624f7fcdd57a292be5768ea1d31fefa926/router_admin_deal.go#L1051-L1063)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/markzhai/GoWebServer/blob/572a5f624f7fcdd57a292be5768ea1d31fefa926/router_admin_deal.go#L1051-L1063)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for _, di := range dis {
var user User
// Skip if problem
if dbConn.Model(&di).Related(&user).Error != nil {
continue
}
buys = append(buys, map[string]interface{}{
"id": di.ID,
"user_id": user.ID,
"user_name": user.FullName,
"deal_investor_state": di.DealInvestorState,
"amount": di.SharesBuyAmount})
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Model 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 572a5f624f7fcdd57a292be5768ea1d31fefa926
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at router_admin_deal.go lines 1051-1063 and inspect the surrounding function to understand how the range variable and related user are used. Review the analyzer context and determine whether this is a real issue, mitigated, or desirable behavior; done means classifying the finding as Bug, Mitigated, or Desirable Behavior with supporting evidence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100