github-vet / github-vet/rangeloop-pointer-findings
markzhai/GoWebServer: router_company.go; 41 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [markzhai/GoWebServer](https://www.github.com/markzhai/GoWebServer) at [router_company.go](https://github.com/markzhai/GoWebServer/blob/572a5f624f7fcdd57a292be5768ea1d31fefa926/router_company.go#L176-L216)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/markzhai/GoWebServer/blob/572a5f624f7fcdd57a292be5768ea1d31fefa926/router_company.go#L176-L216)
Click here to show the 41 line(s) of Go which triggered the analyzer.
```go
for _, d := range ds {
if d.DealState == DealStateOpen {
// Only return if deal is live
deal := map[string]interface{}{
"id": d.ID,
"deal_state": d.DealState,
"deal_special": d.DealSpecial,
"start_date": unixTime(d.StartDate),
"end_date": unixTime(d.EndDate),
"fund_num": d.FundNum,
"actual_price": d.ActualPrice,
"actual_valuation": d.ActualValuation,
"shares_amount": d.SharesAmount,
"shares_left": d.SharesLeft,
"shares_type": d.SharesType,
}
// Add on user specific information if available
var dshs []DealShareholder
dbConn.Model(&d).Related(&dshs)
var dis []DealInvestor
dbConn.Model(&d).Related(&dis)
// Default to none
deal["deal_user_state"] = DealUserStateNone
for _, dsh := range dshs {
if dsh.UserID == uint64(u.ID) {
deal["deal_user_state"] = DealUserStateShareholder
deal["deal_shareholder_state"] = dsh.DealShareholderState
break
}
}
for _, di := range dis {
if di.UserID == uint64(u.ID) {
deal["deal_user_state"] = DealUserStateInvestor
deal["deal_investor_state"] = di.DealInvestorState
break
}
}
ret["deal"] = deal
break
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Model 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 572a5f624f7fcdd57a292be5768ea1d31fefa926
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.