github-vet / github-vet/rangeloop-pointer-findings

myteksi/go-tour: closure/main.go; 7 LoC

Open
#15,051 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [myteksi/go-tour](https://www.github.com/myteksi/go-tour) at [closure/main.go](https://github.com/myteksi/go-tour/blob/e1644c5f37a6bfedbcd637e209aa92a21844093f/closure/main.go#L8-L14)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 12

[Click here to see the code in its original context.](https://github.com/myteksi/go-tour/blob/e1644c5f37a6bfedbcd637e209aa92a21844093f/closure/main.go#L8-L14)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for i, v := range vals {
wg.Add(1)
go func() {
defer wg.Done()
result[i] = v * multiplier
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e1644c5f37a6bfedbcd637e209aa92a21844093f

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect closure/main.go at lines 8-14 and compare the range-loop closure with the analyzer message about variables used in a goroutine. Review the linked commit context and the rangeclosure-findings classification guidance first; done means selecting the appropriate reaction classification for this finding.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.