rdnelson/avala: indexes.go; 26 LoC

Found a possible issue in [rdnelson/avala](https://www.github.com/rdnelson/avala) at [indexes.go](https://github.com/rdnelson/avala/blob/6d57dc8ae03d94d516589db3170954fe88ca72b1/indexes.go#L85-L110)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to index is reassigned at line 103

[Click here to see the code in its original context.](https://github.com/rdnelson/avala/blob/6d57dc8ae03d94d516589db3170954fe88ca72b1/indexes.go#L85-L110)

Click here to show the 26 line(s) of Go which triggered the analyzer.

```go
for _, index := range site.Indices {
progress("Generating index page for %s", index.Name)

t, err := getTemplate(site, "index.tmpl")

if err != nil {
return err
}

outFile := getIndexPath(out, site.Articles[index.First].createdDate)

out, err := os.Create(outFile)
defer out.Close()

if err != nil {
return err
}

site.CurrentIndex = &index

err = t.Execute(out, site)

if err != nil {
return err
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 6d57dc8ae03d94d516589db3170954fe88ca72b1

Read indexes.go lines 85-110 and the linked original context in rdnelson/avala, focusing on the range-loop pointer use and the analyzer's reported reassignment. Decide whether the finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on this issue; completion is the classification reaction.

Written by the indexing model from the issue text.