github-vet / github-vet/rangeloop-pointer-findings
cilium/cilium: pkg/k8s/zz_generated.deepcopy.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [cilium/cilium](https://www.github.com/cilium/cilium) at [pkg/k8s/zz_generated.deepcopy.go](https://github.com/cilium/cilium/blob/dc01471fdabccb8ba3ebdcaf6c3b6bcc4354d465/pkg/k8s/zz_generated.deepcopy.go#L170-L179)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to val is reassigned at line 175
[Click here to see the code in its original context.](https://github.com/cilium/cilium/blob/dc01471fdabccb8ba3ebdcaf6c3b6bcc4354d465/pkg/k8s/zz_generated.deepcopy.go#L170-L179)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for key, val := range *in {
var outVal *cidr.CIDR
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = (*in).DeepCopy()
}
(*out)[key] = outVal
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: dc01471fdabccb8ba3ebdcaf6c3b6bcc4354d465
Contributor guide
No contributing guide indexed for this repository
Research direction
Read pkg/k8s/zz_generated.deepcopy.go around lines 170-179 and inspect the surrounding deepcopy implementation. Determine whether the range-variable reference can cause incorrect behavior in this context, rather than relying only on the analyzer message. Done means classifying the finding as Bug, Mitigated, or Desirable Behavior as requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100