kubevirt/kubevirt: pkg/virt-api/webhooks/validating-webhook/admitters/vms-admitter.go; 95 LoC

Found a possible issue in [kubevirt/kubevirt](https://www.github.com/kubevirt/kubevirt) at [pkg/virt-api/webhooks/validating-webhook/admitters/vms-admitter.go](https://github.com/kubevirt/kubevirt/blob/d7eb9869d58c8df66a2ff2826b2753b9bb239787/pkg/virt-api/webhooks/validating-webhook/admitters/vms-admitter.go#L332-L426)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to volumeRequest is reassigned at line 400

[Click here to see the code in its original context.](https://github.com/kubevirt/kubevirt/blob/d7eb9869d58c8df66a2ff2826b2753b9bb239787/pkg/virt-api/webhooks/validating-webhook/admitters/vms-admitter.go#L332-L426)

Click here to show the 95 line(s) of Go which triggered the analyzer.

```go
for _, volumeRequest := range vm.Status.VolumeRequests {
name := ""
if volumeRequest.AddVolumeOptions != nil && volumeRequest.RemoveVolumeOptions != nil {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "VolumeRequests require either addVolumeOptions or removeVolumeOptions to be set, not both",
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
} else if volumeRequest.AddVolumeOptions != nil {
name = volumeRequest.AddVolumeOptions.Name

_, ok := curVMAddRequestsMap[name]
if ok {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("AddVolume request for [%s] aleady exists", name),
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
}

// Validate the disk is configured properly
if volumeRequest.AddVolumeOptions.Disk == nil {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("AddVolume request for [%s] requires the disk field to be set.", name),
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
} else if volumeRequest.AddVolumeOptions.Disk.DiskDevice.Disk == nil {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("AddVolume request for [%s] requires diskDevice of type 'disk' to be used.", name),
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
} else if volumeRequest.AddVolumeOptions.Disk.DiskDevice.Disk.Bus != "scsi" {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("AddVolume request for [%s] requires disk bus to be 'scsi'. [%s] is not permitted", name, volumeRequest.AddVolumeOptions.Disk.DiskDevice.Disk.Bus),
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
}

newVolume := v1.Volume{
Name: volumeRequest.AddVolumeOptions.Name,
}
if volumeRequest.AddVolumeOptions.VolumeSource.PersistentVolumeClaim != nil {
newVolume.VolumeSource.PersistentVolumeClaim = volumeRequest.AddVolumeOptions.VolumeSource.PersistentVolumeClaim
} else if volumeRequest.AddVolumeOptions.VolumeSource.DataVolume != nil {
newVolume.VolumeSource.DataVolume = volumeRequest.AddVolumeOptions.VolumeSource.DataVolume
}

vmVolume, ok := vmVolumeMap[name]
if ok && !reflect.DeepEqual(newVolume, vmVolume) {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("AddVolume request for [%s] conflicts with an existing volume of the same name on the vmi template.", name),
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
}

vmiVolume, ok := vmiVolumeMap[name]
if ok && !reflect.DeepEqual(newVolume, vmiVolume) {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("AddVolume request for [%s] conflicts with an existing volume of the same name on currently running vmi", name),
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
}

curVMAddRequestsMap[name] = &volumeRequest
} else if volumeRequest.RemoveVolumeOptions != nil {
name = volumeRequest.RemoveVolumeOptions.Name

_, ok := curVMRemoveRequestsMap[name]
if ok {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("RemoveVolume request for [%s] aleady exists", name),
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
}

curVMRemoveRequestsMap[name] = &volumeRequest
} else {
return []metav1.StatusCause{{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "VolumeRequests require one of either addVolumeOptions or removeVolumeOptions to be set",
Field: k8sfield.NewPath("Status", "volumeRequests").String(),
}}, nil
}
newSpec = controller.ApplyVolumeRequestOnVMISpec(newSpec, &volumeRequest)

if vmiExists {
vmi.Spec = *controller.ApplyVolumeRequestOnVMISpec(&vmi.Spec, &volumeRequest)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: d7eb9869d58c8df66a2ff2826b2753b9bb239787