github-vet / github-vet/rangeloop-pointer-findings

cooper/quiki: wiki/category.go; 6 LoC

Open
#14,926 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [cooper/quiki](https://www.github.com/cooper/quiki) at [wiki/category.go](https://github.com/cooper/quiki/blob/13ef0152765747bc1ff667ee7958dec4bb0a904c/wiki/category.go#L534-L539)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to modelInfo is reassigned at line 537

[Click here to see the code in its original context.](https://github.com/cooper/quiki/blob/13ef0152765747bc1ff667ee7958dec4bb0a904c/wiki/category.go#L534-L539)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for modelName, modelInfo := range page.Models {
modelCat := w.GetSpecialCategory(modelName, CategoryTypeModel)
modelCat.Preserve = true // keep until there are no more references
modelCat.ModelInfo = &modelInfo
modelCat.AddPage(w, page)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 13ef0152765747bc1ff667ee7958dec4bb0a904c

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect wiki/category.go at lines 534-539 in the referenced cooper/quiki commit, starting with how ModelInfo is used after the range loop. Determine whether taking the address of modelInfo causes incorrect references, then classify the finding as Bug, Mitigated, or Desirable Behavior according to the linked guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.