github-vet / github-vet/rangeloop-pointer-findings

truechain/truechain-consensus-core: trueconsensus/fastchain/node.go; 44 LoC

Open
#14,853 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [truechain/truechain-consensus-core](https://www.github.com/truechain/truechain-consensus-core) at [trueconsensus/fastchain/node.go](https://github.com/truechain/truechain-consensus-core/blob/1414968a97a8f61cd64f027d6bd0b2b734f1c24b/trueconsensus/fastchain/node.go#L783-L826)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable tx used in defer or goroutine at line 798

[Click here to see the code in its original context.](https://github.com/truechain/truechain-consensus-core/blob/1414968a97a8f61cd64f027d6bd0b2b734f1c24b/trueconsensus/fastchain/node.go#L783-L826)

Click here to show the 44 line(s) of Go which triggered the analyzer.

```go
for _, tx := range blk.Txns {
if _, ok := VerifySender(tx, nd.cfg.Network.N); !ok { // Verify if tx came from client
return false
}

foundTx := make(chan *pb.Transaction, 1)
txInPool := make(chan bool, 1)
go func() {
// Setup timer to track timeout on transaction to appear on pool
timer := time.NewTimer(time.Duration(nd.timeout) * time.Second)
go func(t *time.Timer) {
<-timer.C
txInPool <- false
}(timer)

txHash := common.BytesToHash(tx.Data.Hash)
for {
if t := nd.txPool.Get(txHash); t != nil {
foundTx <- t
txInPool <- true
break
}
}
}()

okchan := make(chan bool, 1)
go func() {
found := <-txInPool
if !found {
okchan <- false // tx not found in txnpool after timeout
}

t := <-foundTx
if t.Data.AccountNonce != tx.Data.AccountNonce {
okchan <- false // tx account nonce from txPool didn't match that in block
}

okchan <- true
}()

if ok := <-okchan; !ok {
return false
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1414968a97a8f61cd64f027d6bd0b2b734f1c24b

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.