github-vet / github-vet/rangeloop-pointer-findings
google/gvisor: runsc/container/state_file.go; 8 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [google/gvisor](https://www.github.com/google/gvisor) at [runsc/container/state_file.go](https://github.com/google/gvisor/blob/85c1c3ed4b8d32c499c53917765acef20cb16248/runsc/container/state_file.go#L174-L181)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to id is reassigned at line 179
[Click here to see the code in its original context.](https://github.com/google/gvisor/blob/85c1c3ed4b8d32c499c53917765acef20cb16248/runsc/container/state_file.go#L174-L181)
Click here to show the 8 line(s) of Go which triggered the analyzer.
```go
for _, id := range ids {
if strings.HasPrefix(id.ContainerID, partialID) {
if rv != nil {
return FullID{}, fmt.Errorf("id %q is ambiguous and could refer to multiple containers: %q, %q", partialID, rv, id)
}
rv = &id
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 85c1c3ed4b8d32c499c53917765acef20cb16248
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with runsc/container/state_file.go around lines 174-181 and read the surrounding lookup logic. Check whether taking a pointer to the range-loop variable can change the selected container or error behavior, then use a reaction to classify the finding as Bug, Mitigated, or Desirable Behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100