github-vet / github-vet/rangeloop-pointer-findings

xuzhiping7/Legend: models/player.go; 3 LoC

Open
#14,788 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [xuzhiping7/Legend](https://www.github.com/xuzhiping7/Legend) at [models/player.go](https://github.com/xuzhiping7/Legend/blob/1c2f0c69ab16321d013872ff28d06466a598e662/models/player.go#L143-L145)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to prop is reassigned at line 144

[Click here to see the code in its original context.](https://github.com/xuzhiping7/Legend/blob/1c2f0c69ab16321d013872ff28d06466a598e662/models/player.go#L143-L145)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, prop := range props {
player.Map_PlayerProp[prop.PropId] = &prop
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1c2f0c69ab16321d013872ff28d06466a598e662

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading models/player.go around lines 143-145 and inspect how Map_PlayerProp is used around this loop. Compare the analyzer's finding with the surrounding Go code, then classify the instance as Bug, Mitigated, or Desirable Behavior using the requested reaction; no test or command is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.