github-vet / github-vet/rangeloop-pointer-findings

Rabbit-OJ/Rabbit-OJ-Judger: mq/types.go; 6 LoC

Open
#14,750 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Rabbit-OJ/Rabbit-OJ-Judger](https://www.github.com/Rabbit-OJ/Rabbit-OJ-Judger) at [mq/types.go](https://github.com/Rabbit-OJ/Rabbit-OJ-Judger/blob/20515da5b1c5778ae1d8d86c148febd8830403d4/mq/types.go#L50-L55)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable message used in defer or goroutine at line 52

[Click here to see the code in its original context.](https://github.com/Rabbit-OJ/Rabbit-OJ-Judger/blob/20515da5b1c5778ae1d8d86c148febd8830403d4/mq/types.go#L50-L55)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for message := range claim.Messages() {
go func() {
JudgeResponseDeliveryChan <- message.Value
}()
session.MarkMessage(message, "")
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 20515da5b1c5778ae1d8d86c148febd8830403d4

Contributor guide

No contributing guide indexed for this repository

Research direction

Open mq/types.go at lines 50-55 and review the range loop, goroutine, and message handling shown in the report. Compare the behavior with the linked analyzer guidance, then leave the requested reaction classifying it as a Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.