github-vet / github-vet/rangeloop-pointer-findings
skycoin/skywire: pkg/snet/network.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [skycoin/skywire](https://www.github.com/skycoin/skywire) at [pkg/snet/network.go](https://github.com/skycoin/skywire/blob/cf82170ead7f24d16e66aca603f10a0675700969/pkg/snet/network.go#L322-L335)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable v used in defer or goroutine at line 326
[Click here to see the code in its original context.](https://github.com/skycoin/skywire/blob/cf82170ead7f24d16e66aca603f10a0675700969/pkg/snet/network.go#L322-L335)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for k, v := range n.clients.Direct {
if v != nil {
wg.Add(1)
go func() {
err := v.Close()
directErrorsMu.Lock()
directErrors[k] = err
directErrorsMu.Unlock()
wg.Done()
}()
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: cf82170ead7f24d16e66aca603f10a0675700969
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.