github-vet / github-vet/rangeloop-pointer-findings

mit-dci/lit: qln/multihop.go; 17 LoC

Open
#14,580 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [mit-dci/lit](https://www.github.com/mit-dci/lit) at [qln/multihop.go](https://github.com/mit-dci/lit/blob/511d703a128dca889b36170d1a1d99af9a02e959/qln/multihop.go#L243-L259)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable mh used in defer or goroutine at line 251

[Click here to see the code in its original context.](https://github.com/mit-dci/lit/blob/511d703a128dca889b36170d1a1d99af9a02e959/qln/multihop.go#L243-L259)

Click here to show the 17 line(s) of Go which triggered the analyzer.

```go
for _, mh := range nd.InProgMultihop {
hash := fastsha256.Sum256(mh.PreImage[:])

if !bytes.Equal(mh.PreImage[:], nullBytes[:]) && bytes.Equal(msg.HHash[:], hash[:]) && mh.Path[len(mh.Path)-1].CoinType == incomingHop.CoinType {
// We already know this. If we have a Preimage, then we're the receiving
// end and we should send a settlement message to the
// predecessor
go func() {
_, err := nd.ClaimHTLC(mh.PreImage)
if err != nil {
logging.Errorf("error claiming HTLC: %s", err.Error())
}
}()

return nil
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 511d703a128dca889b36170d1a1d99af9a02e959

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.