github-vet / github-vet/rangeloop-pointer-findings
kkkmmu/kkkmmu: golang/mru/src/newcache/newcache.go; 15 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [kkkmmu/kkkmmu](https://www.github.com/kkkmmu/kkkmmu) at [golang/mru/src/newcache/newcache.go](https://github.com/kkkmmu/kkkmmu/blob/78544de768c0b1c85cc9e205788df7e47a20f98c/golang/mru/src/newcache/newcache.go#L915-L929)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable f used in defer or goroutine at line 920
[Click here to see the code in its original context.](https://github.com/kkkmmu/kkkmmu/blob/78544de768c0b1c85cc9e205788df7e47a20f98c/golang/mru/src/newcache/newcache.go#L915-L929)
Click here to show the 15 line(s) of Go which triggered the analyzer.
```go
for _, f := range sg.Features {
cs, err := tr.GetCaseByFeature(f)
if err != nil {
go func(err error) {
res <- &result.Result{
Group: f.Group,
SubGroup: f.SubGroup,
Feature: f.Name,
Pass: false,
Message: fmt.Sprintf("Cannot Find Feature: %s\n", f.Name),
}
}(err)
}
cases = append(cases, cs...)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 78544de768c0b1c85cc9e205788df7e47a20f98c
Contributor guide
No contributing guide indexed for this repository
Research direction
Read golang/mru/src/newcache/newcache.go around lines 915-929 and inspect the surrounding loop and goroutine. Compare the captured range variable use with the analyzer report; done means leaving the reaction that classifies the finding as Bug, Mitigated, or Desirable Behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100