github-vet / github-vet/rangeloop-pointer-findings

Kenshin/gnvm: command/command.go; 26 LoC

Open
#14,555 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Kenshin/gnvm](https://www.github.com/Kenshin/gnvm) at [command/command.go](https://github.com/Kenshin/gnvm/blob/e6fa033070bc66d21f1ab69641737920a8cf73a6/command/command.go#L115-L140)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to v was used in a composite literal at line 131

[Click here to see the code in its original context.](https://github.com/Kenshin/gnvm/blob/e6fa033070bc66d21f1ab69641737920a8cf73a6/command/command.go#L115-L140)

Click here to show the 26 line(s) of Go which triggered the analyzer.

```go
for _, v := range args {

v = util.EqualAbs("npm", v)
if v == "npm" {
nodehandle.UninstallNPM()
continue
}

v = util.EqualAbs("ALL", v)
if v == "ALL" {
P(WARING, "'%v' not supported mixed parameters, please usage '%v'. See '%v'.\n", "gnvm uninstall ALL", "gnvm uninstall ALL", "gnvm help uninstall")
continue
}

v = util.EqualAbs("latest", v)
if v == util.LATEST {
util.FormatLatVer(&v, config.GetConfig(config.LATEST_VERSION), true)
}

// check version format
if !util.VerifyNodeVer(v) {
P(ERROR, "%v not an %v Node.js version.\n", v, "valid")
} else {
nodehandle.Uninstall(v)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e6fa033070bc66d21f1ab69641737920a8cf73a6

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.