github-vet / github-vet/rangeloop-pointer-findings

poohvpn/gqlgo: client.go; 15 LoC

Open
#14,553 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [poohvpn/gqlgo](https://www.github.com/poohvpn/gqlgo) at [client.go](https://github.com/poohvpn/gqlgo/blob/02319f8b44ccc13c7c9afd8bcc48a713186785b2/client.go#L271-L285)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to file was used in a composite literal at line 281

[Click here to see the code in its original context.](https://github.com/poohvpn/gqlgo/blob/02319f8b44ccc13c7c9afd8bcc48a713186785b2/client.go#L271-L285)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for fileIndex, file := range o {
path := getPath(singleReq, reqIndex, varName, fileIndex)
if file.Reader == nil {
err = errFileReaderIsNil(path)
return
}
if pathMap, ok := res[file.Reader]; ok {
pathMap.paths = append(pathMap.paths, path)
} else {
res[file.Reader] = &graphQLFileWithPath{
file: &file,
paths: []string{path},
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 02319f8b44ccc13c7c9afd8bcc48a713186785b2

Contributor guide

No contributing guide indexed for this repository

Research direction

Review client.go lines 271-285 at commit 02319f8b44ccc13c7c9afd8bcc48a713186785b2, starting with the range-loop handling and the analyzer message. Determine whether the finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.