github-vet / github-vet/rangeloop-pointer-findings
ichtrojan/fragrance: database/seeder.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [ichtrojan/fragrance](https://www.github.com/ichtrojan/fragrance) at [database/seeder.go](https://github.com/ichtrojan/fragrance/blob/baf6124f918a403da54470e4ea64907c5558b74a/database/seeder.go#L198-L200)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/ichtrojan/fragrance/blob/baf6124f918a403da54470e4ea64907c5558b74a/database/seeder.go#L198-L200)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, bottle := range bottles {
db.Create(&bottle)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Create 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: baf6124f918a403da54470e4ea64907c5558b74a
Contributor guide
No contributing guide indexed for this repository
Research direction
Read database/seeder.go around lines 198-200 and the linked range-loop finding guidance first. Determine whether passing the range variable address to db.Create is a real bug, mitigated behavior, or desirable behavior, then record the appropriate classification reaction; no code change is specified by the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100