github-vet / github-vet/rangeloop-pointer-findings

wolferton/quilt: ioc/container.go; 23 LoC

Open
#14,483 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [wolferton/quilt](https://www.github.com/wolferton/quilt) at [ioc/container.go](https://github.com/wolferton/quilt/blob/c64e1ff700f2789f4c3802dbaaaef5bcf1368247/ioc/container.go#L265-L287)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable fieldName used in defer or goroutine at line 282

[Click here to see the code in its original context.](https://github.com/wolferton/quilt/blob/c64e1ff700f2789f4c3802dbaaaef5bcf1368247/ioc/container.go#L265-L287)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for fieldName, depName := range proto.Dependencies {

fl.LogTracef("%s needs %s", proto.Component.Name, depName)

requiredComponent := cc.allComponents[depName]

if requiredComponent == nil {
message := fmt.Sprintf("No component named %s available (required by %s.%s)", depName, proto.Component.Name, fieldName)
return errors.New(message)
}

requiredInstance := requiredComponent.Instance

targetReflect := reflect.ValueOf(proto.Component.Instance).Elem()

defer func() {
if r := recover(); r != nil {
fl.LogFatalf("Problem setting %s.%s: %s ", proto.Component.Name, fieldName, r)
}
}()

targetReflect.FieldByName(fieldName).Set(reflect.ValueOf(requiredInstance))
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c64e1ff700f2789f4c3802dbaaaef5bcf1368247

Contributor guide

No contributing guide indexed for this repository

Research direction

Open the referenced wolferton/quilt ioc/container.go lines 265-287 and read the surrounding range loop and deferred recovery handler. Check whether fieldName is captured unsafely, then use the linked classification guidance to decide whether this is a Bug, Mitigated, or Desirable Behavior. Done means leaving the matching reaction on this issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.