github-vet / github-vet/rangeloop-pointer-findings
VGTsome/smartStorage: server/comlogic/upStorageLogic.go; 11 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [VGTsome/smartStorage](https://www.github.com/VGTsome/smartStorage) at [server/comlogic/upStorageLogic.go](https://github.com/VGTsome/smartStorage/blob/af0f45eff3cd2b1524ff203d9cf6de14f4eec8c6/server/comlogic/upStorageLogic.go#L145-L155)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/VGTsome/smartStorage/blob/af0f45eff3cd2b1524ff203d9cf6de14f4eec8c6/server/comlogic/upStorageLogic.go#L145-L155)
Click here to show the 11 line(s) of Go which triggered the analyzer.
```go
for _, sspw := range sspws {
_, ssc := service.GetSmartStorageCabinetByCabinetID(sspw.CabinetId)
boxNumStr := strings.Split(ssc.CabinetName, "-")[2]
proNum := getBoxNumFromCommand(boxNumStr, command)
sspw.ProductNewNumber = proNum
sspw.Pass = 2
service.UpdateSmartStoragePassWeight(&sspw)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {UpdateSmartStoragePassWeight 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: af0f45eff3cd2b1524ff203d9cf6de14f4eec8c6
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with server/comlogic/upStorageLogic.go at lines 145-155 and inspect how the range variable is passed to UpdateSmartStoragePassWeight. Trace the related service calls and compare their behavior with the analyzer's range-loop finding. Done means determining whether this is a bug, mitigated case, or desirable behavior and recording the appropriate classification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100