github-vet / github-vet/rangeloop-pointer-findings
kubesphere/notification-manager: pkg/webhook/v1/handler.go; 11 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [kubesphere/notification-manager](https://www.github.com/kubesphere/notification-manager) at [pkg/webhook/v1/handler.go](https://github.com/kubesphere/notification-manager/blob/1f653636d4dc48bbc98a618a5b1e6579bba69188/pkg/webhook/v1/handler.go#L125-L135)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to k is reassigned at line 128
[Click here to see the code in its original context.](https://github.com/kubesphere/notification-manager/blob/1f653636d4dc48bbc98a618a5b1e6579bba69188/pkg/webhook/v1/handler.go#L125-L135)
Click here to show the 11 line(s) of Go which triggered the analyzer.
```go
for k, d := range dm {
var ns *string = nil
if len(k) > 0 {
ns = &k
}
receivers := h.notifierCfg.RcvsFromNs(ns)
n := notify.NewNotification(h.logger, receivers, h.notifierCfg, d)
group.Add(func(stopCh chan interface{}) {
stopCh <- n.Notify(ctx)
})
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 1f653636d4dc48bbc98a618a5b1e6579bba69188
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.