github-vet / github-vet/rangeloop-pointer-findings
ethersphere/swarm: bzzeth/bzzeth.go; 26 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [ethersphere/swarm](https://www.github.com/ethersphere/swarm) at [bzzeth/bzzeth.go](https://github.com/ethersphere/swarm/blob/ae39aaa6dbdbe0df2278dfea645f143c8cd6f3a3/bzzeth/bzzeth.go#L500-L525)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable h used in defer or goroutine at line 506
[Click here to see the code in its original context.](https://github.com/ethersphere/swarm/blob/ae39aaa6dbdbe0df2278dfea645f143c8cd6f3a3/bzzeth/bzzeth.go#L500-L525)
Click here to show the 26 line(s) of Go which triggered the analyzer.
```go
for _, h := range hashes {
wg.Add(1)
go func(hdr chunk.Address) {
defer wg.Done()
header, err := b.getBlockHeaderBzz(ctx, hdr)
if err != nil {
log.Debug("bzzeth.requestAll: netstore.Get can not retrieve chunk", "ref", hex.EncodeToString(h), "err", err)
select {
case missingHeaders <- hdr: // fallback: request header from eth peers
case <-ctx.Done():
}
return
}
// deliver the headers received from Swarm
select {
case deliveries <- header:
case <-ctx.Done():
}
}(h)
select {
case <-ctx.Done():
break BZZ
default:
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ae39aaa6dbdbe0df2278dfea645f143c8cd6f3a3
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.