github-vet / github-vet/rangeloop-pointer-findings
xinghun61/luci-go: luciexe/host/spy.go; 15 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [xinghun61/luci-go](https://www.github.com/xinghun61/luci-go) at [luciexe/host/spy.go](https://github.com/xinghun61/luci-go/blob/35d8de98f0400e02ad3beab50c4162278566da2f/luciexe/host/spy.go#L130-L144)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable build used in defer or goroutine at line 134
[Click here to see the code in its original context.](https://github.com/xinghun61/luci-go/blob/35d8de98f0400e02ad3beab50c4162278566da2f/luciexe/host/spy.go#L130-L144)
Click here to show the 15 line(s) of Go which triggered the analyzer.
```go
for build := range in {
done := make(chan struct{})
go func() {
defer close(done)
out <- build
}()
buildData, err := proto.Marshal(build)
if err != nil {
panic(err)
}
if err := dgStream.WriteDatagram(buildData); err != nil {
panic(err)
}
<-done
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 35d8de98f0400e02ad3beab50c4162278566da2f
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.