github-vet / github-vet/rangeloop-pointer-findings

go-chat-bot/plugins: jira/jira.go; 17 LoC

Open
#14,241 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [go-chat-bot/plugins](https://www.github.com/go-chat-bot/plugins) at [jira/jira.go](https://github.com/go-chat-bot/plugins/blob/00ff43fcf77f4ed1dff31b5946f92ef261f20407/jira/jira.go#L169-L185)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to issue was used in a composite literal at line 181

[Click here to see the code in its original context.](https://github.com/go-chat-bot/plugins/blob/00ff43fcf77f4ed1dff31b5946f92ef261f20407/jira/jira.go#L169-L185)

Click here to show the 17 line(s) of Go which triggered the analyzer.

```go
for _, issue := range newIssues {
channels := notifyNewConfig[issue.Fields.Project.Key]
for _, notifyChan := range channels {
log.Printf("Notifying %s about new %s %s", notifyChan,
issue.Fields.Type.Name,
issue.Key)
template := defaultTemplateNew
config, found := channelConfigs[notifyChan]
if found {
template = config.TemplateNew
}
ret = append(ret, bot.CmdResult{
Message: formatIssue(&issue, notifyChan, template),
Channel: notifyChan,
})
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 00ff43fcf77f4ed1dff31b5946f92ef261f20407

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with jira/jira.go lines 169-185 at commit 00ff43fcf77f4ed1dff31b5946f92ef261f20407, then inspect the surrounding range-loop behavior and formatIssue usage. Decide whether the analyzer finding is a Bug, Mitigated, or Desirable Behavior, and leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.