github-vet / github-vet/rangeloop-pointer-findings

samalws/uwecode: optimize/optimize.go; 20 LoC

Open
#14,209 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [samalws/uwecode](https://www.github.com/samalws/uwecode) at [optimize/optimize.go](https://github.com/samalws/uwecode/blob/79eafb7127ba03535fbfbcedb691d4f8edda1f69/optimize/optimize.go#L23-L42)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable opt used in defer or goroutine at line 25

[Click here to see the code in its original context.](https://github.com/samalws/uwecode/blob/79eafb7127ba03535fbfbcedb691d4f8edda1f69/optimize/optimize.go#L23-L42)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, opt := range opts {
go func() {
str := opt.ConversionFunc(obj, func(a core.Obj, _ core.GlobalState) string { return OptimizeObjHelper(opts, optsUsed, a, newState) }, newState)
if str == "" {
newState.WaitGroup.Done()
return
}
mutex.Lock()
if returnVal == "" {
returnVal = str
}
select {
case <-newState.Stop:
default:
close(newState.Stop)
}
mutex.Unlock()
newState.WaitGroup.Done()
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 79eafb7127ba03535fbfbcedb691d4f8edda1f69

Contributor guide

No contributing guide indexed for this repository

Research direction

Review optimize/optimize.go at lines 23-42 and the analyzer message about the range-loop variable used by the goroutine. Check the referenced commit and surrounding code to determine whether this is a real bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.