github-vet / github-vet/rangeloop-pointer-findings

gocircuit/escher: kit/github.com/ChimeraCoder/anaconda/twitter.go; 39 LoC

Open
#14,207 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gocircuit/escher](https://www.github.com/gocircuit/escher) at [kit/github.com/ChimeraCoder/anaconda/twitter.go](https://github.com/gocircuit/escher/blob/7782d427a7269c855b4211e5b25e0858a1fc557a/kit/github.com/ChimeraCoder/anaconda/twitter.go#L218-L256)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable q used in defer or goroutine at line 239

[Click here to see the code in its original context.](https://github.com/gocircuit/escher/blob/7782d427a7269c855b4211e5b25e0858a1fc557a/kit/github.com/ChimeraCoder/anaconda/twitter.go#L218-L256)

Click here to show the 39 line(s) of Go which triggered the analyzer.

```go
for q := range c.queryQueue {
url := q.url
form := q.form
data := q.data //This is where the actual response will be written
method := q.method

response_ch := q.response_ch

if c.bucket != nil {
<-c.bucket.SpendToken(1)
}

err := c.execQuery(url, form, data, method)

// Check if Twitter returned a rate-limiting error
if err != nil {
if apiErr, ok := err.(*ApiError); ok {
if isRateLimitError, nextWindow := apiErr.RateLimitCheck(); isRateLimitError && !c.returnRateLimitError {
// If this is a rate-limiting error, re-add the job to the queue
// TODO it really should preserve order
go func() {
c.queryQueue <- q
}()

delay := nextWindow.Sub(time.Now())
<-time.After(delay)

// Drain the bucket (start over fresh)
if c.bucket != nil {
c.bucket.Drain()
}

continue
}
}
}

response_ch <- response{data, err}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7782d427a7269c855b4211e5b25e0858a1fc557a

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.