github-vet / github-vet/rangeloop-pointer-findings

piupuer/gin-web: initialize/data.go; 10 LoC

Open
#14,195 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [piupuer/gin-web](https://www.github.com/piupuer/gin-web) at [initialize/data.go](https://github.com/piupuer/gin-web/blob/0e4bc54bc8b04f1c3cfbe34cb91f290db35e78a6/initialize/data.go#L696-L705)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/piupuer/gin-web/blob/0e4bc54bc8b04f1c3cfbe34cb91f290db35e78a6/initialize/data.go#L696-L705)

Click here to show the 10 line(s) of Go which triggered the analyzer.

```go
for _, menu := range menus {
oldMenu := models.SysMenu{}
err := global.Mysql.Where("id = ?", menu.Id).First(&oldMenu).Error
if errors.Is(err, gorm.ErrRecordNotFound) {
global.Mysql.Create(&menu)
}
if len(menu.Children) > 0 {
createMenu(menu.Children)
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Create 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0e4bc54bc8b04f1c3cfbe34cb91f290db35e78a6

Contributor guide

No contributing guide indexed for this repository

Research direction

Read initialize/data.go around lines 696-705 and inspect how the range variable menu and its Children are used. Check whether the database calls or recursive createMenu path retain or pass a pointer to the loop variable, then classify the finding as Bug, Mitigated, or Desirable Behavior based on the observed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.