github-vet / github-vet/rangeloop-pointer-findings

TykTechnologies/tyk-k8s: tyk/tyk.go; 6 LoC

Open
#14,158 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [TykTechnologies/tyk-k8s](https://www.github.com/TykTechnologies/tyk-k8s) at [tyk/tyk.go](https://github.com/TykTechnologies/tyk-k8s/blob/60f560e173918f318f73573ff5d6082eafb83fbe/tyk/tyk.go#L272-L277)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to s is reassigned at line 274

[Click here to see the code in its original context.](https://github.com/TykTechnologies/tyk-k8s/blob/60f560e173918f318f73573ff5d6082eafb83fbe/tyk/tyk.go#L272-L277)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, s := range allServices {
if cSlug == s.Slug {
o.LegacyAPIDef = &s
toUpdate[cSlug] = o
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 60f560e173918f318f73573ff5d6082eafb83fbe

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect tyk/tyk.go lines 272-277 and the linked analyzer context; start by checking how the range variable s is referenced in the loop. Use the linked classification guidance to decide whether this is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.