github-vet / github-vet/rangeloop-pointer-findings
mkvoya/elehackathon: src/github.com/mediocregopher/radix.v2/util/scan.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [mkvoya/elehackathon](https://www.github.com/mkvoya/elehackathon) at [src/github.com/mediocregopher/radix.v2/util/scan.go](https://github.com/mkvoya/elehackathon/blob/1f01a170835bb82b21b1d559216ad440db45ff50/src/github.com/mediocregopher/radix.v2/util/scan.go#L62-L74)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable client used in defer or goroutine at line 66
[Click here to see the code in its original context.](https://github.com/mkvoya/elehackathon/blob/1f01a170835bb82b21b1d559216ad440db45ff50/src/github.com/mediocregopher/radix.v2/util/scan.go#L62-L74)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for _, client := range clients {
cch := make(chan string)
var err error
go func() {
err = scanSingle(client, cch, "SCAN", "", pattern)
}()
for key := range cch {
ch <- key
}
if err != nil {
return err
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 1f01a170835bb82b21b1d559216ad440db45ff50
Contributor guide
No contributing guide indexed for this repository
Research direction
Read src/github.com/mediocregopher/radix.v2/util/scan.go at lines 62-74 and compare the analyzer's warning about client with the shown goroutine. Decide whether the reported range-loop capture is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100