github-vet / github-vet/rangeloop-pointer-findings

spaceuptech/space-cloud: gateway/modules/eventing/routine.go; 3 LoC

Open
#14,058 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [spaceuptech/space-cloud](https://www.github.com/spaceuptech/space-cloud) at [gateway/modules/eventing/routine.go](https://github.com/spaceuptech/space-cloud/blob/1f49871252d45395478fdf0b0bff1435b6d9e8e8/gateway/modules/eventing/routine.go#L35-L37)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to t at line 36 may start a goroutine

[Click here to see the code in its original context.](https://github.com/spaceuptech/space-cloud/blob/1f49871252d45395478fdf0b0bff1435b6d9e8e8/gateway/modules/eventing/routine.go#L35-L37)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for t := range m.tickerStaged.C {
m.processStagedEvents(&t)
}

```

Click here to show extra information the analyzer produced.

```
The following graphviz dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
digraph G {
"(processStagedEvents, 1)" -> {"(processStagedEvent, 1)";"(Read, 5)";}
"(Read, 3)" -> {"(New, 1)";}
"(invokeWebhook, 6)" -> {"(New, 1)";}
"(Read, 5)" -> {"(Read, 3)";}
"(New, 1)" -> {"(New, 3)";}
"(New, 3)" -> {"(initDriver, 2)";}
"(initDriver, 2)" -> {"(NewIstioDriver, 2)";}
"(NewIstioDriver, 2)" -> {}
"(processStagedEvent, 1)" -> {"(invokeWebhook, 6)";}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1f49871252d45395478fdf0b0bff1435b6d9e8e8

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in gateway/modules/eventing/routine.go at lines 35-37 and inspect processStagedEvents and processStagedEvent. Follow the analyzer's listed call path to determine whether passing the range variable reference can cause an incorrect capture or race. Done means leaving the appropriate Bug, Mitigated, or Desirable Behavior reaction based on that review.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.