github-vet / github-vet/rangeloop-pointer-findings

lon9/qna: question_controller.go; 4 LoC

Open
#14,011 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [lon9/qna](https://www.github.com/lon9/qna) at [question_controller.go](https://github.com/lon9/qna/blob/15e1a327e5adcaf194c6f7a9086e0c3636e1d58d/question_controller.go#L29-L32)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/lon9/qna/blob/15e1a327e5adcaf194c6f7a9086e0c3636e1d58d/question_controller.go#L29-L32)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for i, v := range questions {
db.Model(&v).Related(&questions[i].Comments)
db.Model(&v).Related(&questions[i].Selections)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Model 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 15e1a327e5adcaf194c6f7a9086e0c3636e1d58d

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with question_controller.go lines 29-32 in the linked lon9/qna commit and inspect how the range variable v is used in the two Related calls. Read the analyzer details in this issue and the referenced code context to determine whether this is a real range-loop pointer problem, mitigated behavior, or desirable behavior. Record the appropriate classification once the finding is understood.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.