github-vet / github-vet/rangeloop-pointer-findings

tikv/tikv-operator: pkg/apis/tikv/v1alpha1/zz_generated.deepcopy.go; 13 LoC

Open
#13,972 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tikv/tikv-operator](https://www.github.com/tikv/tikv-operator) at [pkg/apis/tikv/v1alpha1/zz_generated.deepcopy.go](https://github.com/tikv/tikv-operator/blob/c29847e78c7986f6d4ad6899319a857a1ea35c86/pkg/apis/tikv/v1alpha1/zz_generated.deepcopy.go#L382-L394)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 387

[Click here to see the code in its original context.](https://github.com/tikv/tikv-operator/blob/c29847e78c7986f6d4ad6899319a857a1ea35c86/pkg/apis/tikv/v1alpha1/zz_generated.deepcopy.go#L382-L394)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal []PDStoreLabel
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(PDStoreLabels, len(*in))
for i := range *in {
(*in)[i].DeepCopyInto(&(*out)[i])
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c29847e78c7986f6d4ad6899319a857a1ea35c86

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.