github-vet / github-vet/rangeloop-pointer-findings
Terry-Mao/gosnowflake: pprof.go; 8 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [Terry-Mao/gosnowflake](https://www.github.com/Terry-Mao/gosnowflake) at [pprof.go](https://github.com/Terry-Mao/gosnowflake/blob/1c0fd083d4f382625763427f7956720ab08c76e2/pprof.go#L32-L39)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable addr used in defer or goroutine at line 34
[Click here to see the code in its original context.](https://github.com/Terry-Mao/gosnowflake/blob/1c0fd083d4f382625763427f7956720ab08c76e2/pprof.go#L32-L39)
Click here to show the 8 line(s) of Go which triggered the analyzer.
```go
for _, addr := range MyConf.PprofBind {
go func() {
if err := http.ListenAndServe(addr, pprofServeMux); err != nil {
log.Error("http.ListenAndServe(\"%s\", pproServeMux) error(%v)", addr)
panic(err)
}
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 1c0fd083d4f382625763427f7956720ab08c76e2
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with pprof.go at lines 32-39 and inspect how the PprofBind range variable is used inside the goroutine. Confirm the analyzer finding and review the surrounding pprof setup to determine the intended address behavior; done means the reported range-loop capture issue is resolved without changing listener behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100