github-vet / github-vet/rangeloop-pointer-findings

DanNixon/voile: cmd/root.go; 32 LoC

Open
#13,936 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [DanNixon/voile](https://www.github.com/DanNixon/voile) at [cmd/root.go](https://github.com/DanNixon/voile/blob/a74ccbdd741ee7a727dadbbeafd2aa1c5d4fc13c/cmd/root.go#L80-L111)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to bm was used in a composite literal at line 82

[Click here to see the code in its original context.](https://github.com/DanNixon/voile/blob/a74ccbdd741ee7a727dadbbeafd2aa1c5d4fc13c/cmd/root.go#L80-L111)

Click here to show the 32 line(s) of Go which triggered the analyzer.

```go
for _, bm := range bmks.Bookmarks {
// Check if this bookmark should be excluded from the results
if !includeBookmark(&d, &bm) {
continue
}

if jsonFlag {
// Add bookmark to filtered list for JSON output
filteredBookmarks = append(filteredBookmarks, bm)
} else {
// Output to console in standard format
if i > 0 {
fmt.Println()
}
fmt.Println(FormatBookmark(&bm, i))
}

// Buffer URLs for clipboard copy
if copyFlag {
if i > 0 {
clipboardBuffer.WriteString("\n")
}
clipboardBuffer.WriteString(bm.Url.String())
}

// Open URL in browser
if openFlag {
open.Run(bm.Url.String())
}

i++
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: a74ccbdd741ee7a727dadbbeafd2aa1c5d4fc13c

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in cmd/root.go around lines 80-111 and trace the range over bmks.Bookmarks, especially the calls to includeBookmark and FormatBookmark. Check whether the referenced bookmark values remain correct across JSON output, formatting, clipboard buffering, and browser opening; done means determining whether the analyzer finding affects behavior and recording the appropriate classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.