github-vet / github-vet/rangeloop-pointer-findings
LapisBot/Lapislazuli: bot/bot.go; 6 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [LapisBot/Lapislazuli](https://www.github.com/LapisBot/Lapislazuli) at [bot/bot.go](https://github.com/LapisBot/Lapislazuli/blob/924e1ad34ceca02e516dc40b2cb9c568c1b963d5/bot/bot.go#L38-L43)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable ircbot used in defer or goroutine at line 40
[Click here to see the code in its original context.](https://github.com/LapisBot/Lapislazuli/blob/924e1ad34ceca02e516dc40b2cb9c568c1b963d5/bot/bot.go#L38-L43)
Click here to show the 6 line(s) of Go which triggered the analyzer.
```go
for _, ircbot := range bot.irc {
go func() {
ircbot.Disconnect()
wg.Done()
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 924e1ad34ceca02e516dc40b2cb9c568c1b963d5
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with bot/bot.go lines 38-43 and inspect the surrounding bot shutdown flow to understand how the range values and goroutines are intended to interact. Confirm the reported range-loop capture issue and run the repository's existing checks; done means the shutdown behavior is correct for every bot and the analyzer warning no longer applies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100