github-vet / github-vet/rangeloop-pointer-findings

skyeidos/go-spider: src/spider/engine/engine.go; 10 LoC

Open
#13,872 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [skyeidos/go-spider](https://www.github.com/skyeidos/go-spider) at [src/spider/engine/engine.go](https://github.com/skyeidos/go-spider/blob/e1dd6a64a92afdfee705a15f5c0e09adf8ffc7b6/src/spider/engine/engine.go#L34-L43)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable result used in defer or goroutine at line 36

[Click here to see the code in its original context.](https://github.com/skyeidos/go-spider/blob/e1dd6a64a92afdfee705a15f5c0e09adf8ffc7b6/src/spider/engine/engine.go#L34-L43)

Click here to show the 10 line(s) of Go which triggered the analyzer.

```go
for result := range resultChannel {
go func() {
for _, request := range result.Request {
e.Scheduler.Submit(request)
}
}()
go func() {
itemChannel <- result.Items
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e1dd6a64a92afdfee705a15f5c0e09adf8ffc7b6

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/spider/engine/engine.go at lines 34-43 and inspect how the two goroutines use result.Request and result.Items inside the range loop. Confirm that each goroutine handles the intended iteration's result; done means the range-loop capture warning is resolved without changing request submission or item delivery.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.