github-vet / github-vet/rangeloop-pointer-findings

dhound-io/dhound-traffic-monitor: network_monitor.go; 16 LoC

Open
#13,861 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [dhound-io/dhound-traffic-monitor](https://www.github.com/dhound-io/dhound-traffic-monitor) at [network_monitor.go](https://github.com/dhound-io/dhound-traffic-monitor/blob/d822191dd27e2b15eb3df50a79d4818cd8087f0d/network_monitor.go#L108-L123)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to device is reassigned at line 110

[Click here to see the code in its original context.](https://github.com/dhound-io/dhound-traffic-monitor/blob/d822191dd27e2b15eb3df50a79d4818cd8087f0d/network_monitor.go#L108-L123)

Click here to show the 16 line(s) of Go which triggered the analyzer.

```go
for _, device := range devices {
intf := &NetInterfaceInfo{}
intf.NetInterface = &device
intf.Name = device.Name
intf.Active = false
interfaces = append(interfaces, intf)

for _, address := range device.Addresses {
ip := address.IP.String()
intf.Addresses = append(intf.Addresses, ip)

if !strings.Contains(ip, "127.0.0.1") && Ipv4Validator.MatchString(ip) {
intf.Active = true
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: d822191dd27e2b15eb3df50a79d4818cd8087f0d

Contributor guide

No contributing guide indexed for this repository

Research direction

Read network_monitor.go at lines 108-123, especially the range over devices and the assignment of the device reference. Compare the analyzer finding with the surrounding code, then leave the reaction that classifies it as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.