github-vet / github-vet/rangeloop-pointer-findings
baseli/ddns: cmd/main.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [baseli/ddns](https://www.github.com/baseli/ddns) at [cmd/main.go](https://github.com/baseli/ddns/blob/2786c02985733f5ad3c6ac5d544e196bbad48611/cmd/main.go#L96-L107)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable domain used in defer or goroutine at line 99
[Click here to see the code in its original context.](https://github.com/baseli/ddns/blob/2786c02985733f5ad3c6ac5d544e196bbad48611/cmd/main.go#L96-L107)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for _, domain := range item.Domains {
if domain.RecordType == ipType {
go func() {
err := val.Request.Update(domain.Domain, domain.RecordType, domain.SubDomain, ip)
if err != nil {
log.Println(err)
} else {
log.Println("update dns success, ", domain.Domain, domain.RecordType, domain.SubDomain, ip)
}
}()
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 2786c02985733f5ad3c6ac5d544e196bbad48611
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.